Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conversion QS, Pre-Upgrade QS, and Edits to Pre-conversion. #175

Merged
merged 8 commits into from
Apr 22, 2024

Conversation

arburka
Copy link
Contributor

@arburka arburka commented Apr 12, 2024

Added new convert qs

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@arburka arburka closed this Apr 15, 2024
@arburka arburka reopened this Apr 15, 2024
@arburka arburka marked this pull request as draft April 15, 2024 17:54
@arburka arburka changed the title added new convert qs [WIP] added new convert qs Apr 15, 2024
@Hyperkid123
Copy link
Collaborator

/ok-to-test

@arburka arburka changed the title [WIP] added new convert qs Add Conversion QS, Pre-Upgrade QS, and Edits to Pre-conversion. Apr 18, 2024
@arburka arburka marked this pull request as ready for review April 18, 2024 20:40
@arburka
Copy link
Contributor Author

arburka commented Apr 18, 2024

Hello @Hyperkid123 ! Hope you are feeling better :(

I let the content people know this is ready for them to review. If nothing gets mentioned can you take care of this early next week?

@Hyperkid123
Copy link
Collaborator

@arburka OFC. I think there might be a typo in s doc/metadata name. CI throws this error:

22:36:15 #13 0.720 Help topic validation error. Error occured in:  docs/quickstarts/insights-tasks-convert/insights-tasks-pre-conversion.yaml
22:36:15 #13 0.722 panic: open docs/quickstarts/insights-tasks-convert/insights-tasks-pre-conversion.yaml: no such file or directory

@arburka
Copy link
Contributor Author

arburka commented Apr 19, 2024

@Hyperkid123 Thank you! Fixed!

@Hyperkid123 Hyperkid123 merged commit aa8889d into RedHatInsights:main Apr 22, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants