You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected expanded and expanded-index attributes functionality
Improved demo naming and added comment to header usage in default demo
Todo
Add changeset, determine what level of change this is...
Does this actually change the expected API? Currently if you add expanded to a header it does not unless on firstUpdated update the accordions state. I felt like that was incorrect expectation and that the panel should belong wot the header and expand with it when the header is given expanded. However even PFE accordion you need to add expanded to both the header and the panel in order for the pair to be expanded. Also you can now use expanded-index and expanded together now as both just feed the expandedIndexSet.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
expanded
andexpanded-index
attributes functionalityTodo
Does this actually change the expected API? Currently if you add
expanded
to a header it does not unless onfirstUpdated
update the accordions state. I felt like that was incorrect expectation and that the panel should belong wot the header and expand with it when the header is givenexpanded
. However even PFE accordion you need to addexpanded
to both the header and the panel in order for the pair to be expanded. Also you can now useexpanded-index
andexpanded
together now as both just feed theexpandedIndexSet
.Closes #2032
Closes #2019
Testing Instructions
Expanded Index Demo
Expanded Attribute Demo
Notes to Reviewers