Skip to content

Commit

Permalink
Split installer options and launch options
Browse files Browse the repository at this point in the history
Closes qzind#771
  • Loading branch information
tresf committed Mar 18, 2021
1 parent d376835 commit a795fab
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion ant/project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ project.name=QZ Tray
project.filename=qz-tray
project.datadir=qz

launch.opts=-Xms512m -Djna.nosys=true
install.opts=-Djna.nosys=true
launch.opts=-Xms512m ${install.opts}
launch.overrides=QZ_OPTS

src.dir=${basedir}/src
Expand Down
4 changes: 2 additions & 2 deletions ant/windows/windows-installer.nsi.in
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ RequestExecutionLevel admin
SetDetailsPrint textonly
DetailPrint "Running ${step}..."
SetDetailsPrint listonly
DetailPrint 'Running ${step}: "$java" ${launch.opts} -jar "$OUTDIR\${project.filename}.jar" "${step}" "${option}" "${value}"'
DetailPrint 'Running ${step}: "$java" ${install.opts} -jar "$OUTDIR\${project.filename}.jar" "${step}" "${option}" "${value}"'
SetDetailsPrint both
ClearErrors
nsExec::ExecToLog '"$java" ${launch.opts} -jar "$OUTDIR\${project.filename}.jar" "${step}" "${option}" "${value}"'
nsExec::ExecToLog '"$java" ${install.opts} -jar "$OUTDIR\${project.filename}.jar" "${step}" "${option}" "${value}"'
Pop $0
${If} "$0" != "0"
Abort "Installation failed during ${step} step. Please check log for details."
Expand Down
4 changes: 2 additions & 2 deletions ant/windows/windows-uninstaller.nsi.in
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ Section
SetDetailsPrint none ; Temporarily suppress details
SetOutPath $DELETE_DIR
SetDetailsPrint listonly
DetailPrint 'Running uninstall: "$java" ${launch.opts} -jar "$DELETE_DIR\${project.filename}.jar" uninstall'
DetailPrint 'Running uninstall: "$java" ${install.opts} -jar "$DELETE_DIR\${project.filename}.jar" uninstall'
ClearErrors
nsExec::ExecToLog '"$java" ${launch.opts} -jar "$DELETE_DIR\${project.filename}.jar" uninstall'
nsExec::ExecToLog '"$java" ${install.opts} -jar "$DELETE_DIR\${project.filename}.jar" uninstall'
Pop $0
${If} "$0" != "0"
Abort "Uninstall failed."
Expand Down

0 comments on commit a795fab

Please sign in to comment.