Fix #200 - Crash When Placing a Comparator Reading a Large Energy Storage #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200
Changes
ComparatorOutputProvider
to standardizing getting a comparator value from a block entityRedstoneAddonBlockEntity.RedstoneControllable
overridesComparatorOutputProvider#getComparatorOutput
and always returns0
since only the redstone addon should be used to read comparator output.Fix
Initial Cause: Invalid casting in SmallStorageBlock
We now cast to
ComparatorOutputProvider
since all block entities of a block with a comparator output should be its child. SinceRedstoneAddonBlockEntity.RedstoneControllable
overridesComparatorOutputProvider#getComparatorOutput
there is no longer an invalid cast.