Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top up functionlaity for fork arbitrator #213

Closed
wants to merge 2 commits into from
Closed

Top up functionlaity for fork arbitrator #213

wants to merge 2 commits into from

Conversation

josojo
Copy link
Collaborator

@josojo josojo commented Feb 6, 2024

First part of #205

@josojo josojo requested a review from edmundedgar February 6, 2024 20:48
edmundedgar
edmundedgar approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@edmundedgar edmundedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My inclination would have been to leave this out and keep it simple as this will probably never happen and you can get the same result by cancelling then requesting again, but I'm not strongly opposed to it and the code looks fine.

@josojo
Copy link
Collaborator Author

josojo commented Feb 7, 2024

Yeah, you are right. Let's keep it short

@josojo josojo closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundedgar edmundedgar edmundedgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josojo @edmundedgar