Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarly disable hardhat test in CI #212

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Temporarly disable hardhat test in CI #212

merged 1 commit into from
Feb 7, 2024

Conversation

josojo
Copy link
Collaborator

@josojo josojo commented Feb 6, 2024

Disabling is done, since a dependency issue is prevailing.
Locally, the tests are working well.

@josojo josojo marked this pull request as ready for review February 6, 2024 14:30
@josojo josojo changed the title newer commonjs repo Temporarly disable hardhat test in CI Feb 6, 2024
@josojo josojo requested a review from edmundedgar February 6, 2024 14:31
Copy link
Contributor

@edmundedgar edmundedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok but I thought we were going to just disable those two failing tests and keep the rest of the ci?

(I'm ok either way)

@josojo
Copy link
Collaborator Author

josojo commented Feb 7, 2024

This pr disables exactly these two hardhat tests and nothing else. ( i could have done it more explicit, but I think its not worth it)

@josojo josojo merged commit 6ac21f2 into main Feb 7, 2024
4 checks passed
edmundedgar added a commit that referenced this pull request Feb 22, 2024
edmundedgar added a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants