Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests fail on compilation warnings #190

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Make tests fail on compilation warnings #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- name: Run Forge tests
run: |
forge test -vvv
forge test --deny-warnings -vvv
id: test


Expand Down
1 change: 0 additions & 1 deletion test/ForkableBridge.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ contract ForkableBridgeTest is Test {
bytes32 newDepositRoot = forkableBridge.getDepositRoot();

// If globalExitRootManager is called, it should revert since there is no mock in place.
address forkmanager = forkableBridge.forkmanager();
vm.expectRevert();
vm.prank(forkmanager);
forkableBridge.createChildren();
Expand Down