Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More custom errors instead of revert strings #179

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

josojo
Copy link
Collaborator

@josojo josojo commented Jan 10, 2024

No description provided.

@josojo josojo requested a review from edmundedgar January 10, 2024 17:23
Copy link
Contributor

@edmundedgar edmundedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one place that changes the logic where it may not have intended to

contracts/L2ForkArbitrator.sol Show resolved Hide resolved
@josojo josojo merged commit 265c413 into main Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants