Skip to content

Commit

Permalink
build(deps)!: drop support for EOL Python 3.7
Browse files Browse the repository at this point in the history
Python 3.7 support ended in July 2023, and package updates will no longer
be published for it, so we won't be able to apply all CVE patches if we
want to keep supporting Python 3.7.

While there are good reasons to keep supporting Python 3.7 for g2p, there
aren't for ReadAlongs/Studio: our CLI users have enough technical
background to bump Python if need be, while the Studio-Web meets the
requirements of our less technical users.

BREAKING CHANGE: Python 3.7 is no longer supported
  • Loading branch information
joanise committed Mar 26, 2024
1 parent 787ead4 commit edaca6a
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/matrix-tests.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This matrix testing is for versions not already exercised by tests.yml
# For regular pushes, we just test the baseline Python version, but when pushing
# For regular pushes, we just test the minimum Python version, but when pushing
# to main or release, we want to exercise the full matrix.
name: Run Matrix Tests
on:
Expand All @@ -10,7 +10,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.7"
python-version: "3.8"
cache: "pip"

- name: Install Python dependencies
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.7"
python-version: "3.8"
cache: "pip"

- name: Install Python dependencies
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
build:
os: ubuntu-20.04
tools:
python: "3.7"
python: "3.8"
jobs:
post_install:
- echo "Installing Studio itself in its current state"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Optionally a book can be generated as a standalone HTML page, XHTML, Praat TextG

Before you can install the ReadAlong Studio, you will need to install these dependencies:

- Python, version 3.7 or higher,
- Python, version 3.8 or higher,
- [FFmpeg](https://ffmpeg.org/),
- a C compiler,
- Git (optional, needed to get the current development version).
Expand Down
4 changes: 2 additions & 2 deletions readalongs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

VERSION = "1.0"

if sys.version_info < (3, 7, 0): # pragma: no cover
if sys.version_info < (3, 8, 0): # pragma: no cover
sys.exit(
f"Python 3.7 or more recent is required. You are using {sys.version}. "
f"Python 3.8 or more recent is required. You are using {sys.version}. "
"Please use a newer version of Python."
)
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
setup(
name="readalongs",
license="MIT",
python_requires=">=3.7",
python_requires=">=3.8",
version=VERSION,
description="ReadAlong Studio",
url="https://github.com/ReadAlongs/Studio",
Expand Down

0 comments on commit edaca6a

Please sign in to comment.