fix: Merge extension only when patch executes #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LisoUseInAIKyrios
approved these changes
Oct 26, 2024
oSumAtrIX
force-pushed
the
fix/merge-extensions-at-patch-execution
branch
from
b0bd428 to
1f0eab3
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2024
# [21.0.0-dev.1](v20.0.2...v21.0.0-dev.1) (2024-10-27) ### Bug Fixes * Merge extension only when patch executes ([#315](#315)) ([aa472eb](aa472eb)) ### Features * Improve Fingerprint API ([#316](#316)) ([0abf1c6](0abf1c6)) * Improve various APIs ([#317](#317)) ([b824978](b824978)) ### BREAKING CHANGES * Various APIs have been changed. * Many APIs have been changed.
oSumAtrIX
added a commit
that referenced
this pull request
Nov 5, 2024
oSumAtrIX
pushed a commit
that referenced
this pull request
Nov 5, 2024
# [21.0.0-dev.1](v20.0.2...v21.0.0-dev.1) (2024-10-27) ### Bug Fixes * Merge extension only when patch executes ([#315](#315)) ([aa472eb](aa472eb)) ### Features * Improve Fingerprint API ([#316](#316)) ([0abf1c6](0abf1c6)) * Improve various APIs ([#317](#317)) ([b824978](b824978)) ### BREAKING CHANGES * Various APIs have been changed. * Many APIs have been changed.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
# [21.0.0](v20.0.2...v21.0.0) (2024-11-05) ### Bug Fixes * Match fingerprint before delegating the match property ([5d996de](5d996de)) * Merge extension only when patch executes ([#315](#315)) ([aa472eb](aa472eb)) ### Features * Improve Fingerprint API ([#316](#316)) ([0abf1c6](0abf1c6)) * Improve various APIs ([#317](#317)) ([b824978](b824978)) * Move fingerprint match members to fingerprint for ease of access by using context receivers ([0746c22](0746c22)) ### Performance Improvements * Use smallest lookup map for strings ([1358d3f](1358d3f)) ### BREAKING CHANGES * Various APIs have been changed. * Many APIs have been changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how extensions are merged. Before, all extensions were merged unconditionally regardless of whether a patch succeeded. This was done to reduce memory overhead since the lookup map for the merge could be removed after all extensions were merged. Now, an extension of a patch is merged right before the patch is executed. This requires the lookup map to be kept in memory as long as the patches are executing. This should not be much of a problem. The maps are cleared after all patches were executed