NW6 | Rabia Avci | Full-Stack-Project | Week-2 | New video form #26
Conversation
✅ Deploy Preview for watch-next-cyf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| background-color: #007bff; | ||
| color: #fff; | ||
| font-size: 16px; | ||
| cursor: pointer; |
There was a problem hiding this comment.
Is there any particular reason you're setting the cursor to pointer here? It should be pointer by default here https://developer.mozilla.org/en-US/docs/Web/CSS/cursor
There was a problem hiding this comment.
When its default it keeps an arrow, i wanted to make it a hand icon when hovering over the element :)
| } | ||
|
|
||
| button:hover { | ||
| background-color: #0056b3; |
There was a problem hiding this comment.
Always nice to have a hover style for buttons.
Overall, I really like what you're doing here, good use of flex and nice touches like border-radius and padding in inputs throughtout
client/src/NewVideoForm.jsx
Outdated
| "Content-Type": "application/json", | ||
| }, | ||
| body: JSON.stringify({ | ||
| title: e.target.title.value, |
There was a problem hiding this comment.
This is a perfectly acceptable way of handling inputs, especially for a small form, however it's worth being aware that there's a different (not necessarily better, it just serves a different purpose) way of doing this that you may need someday
https://react.dev/reference/react-dom/components/input#controlling-an-input-with-a-state-variable
Signed-off-by: Rabia Avci <[email protected]>
Completed these tasks for this ticket: