Issue #53 Updated to Clojure 1.7 #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close Raynes#53. Bump Clojure to the latest stable release, 1.7.0. The only major switch was avoiding the ring-clojure/ring-anti-forgery 403 permissions error that was being thrown when POST to /tutorial. The library is included in noir.util.middleware from ring-clojure/ring-defaults. For more information about ring-anti-forgery and POST see ring-clojure/ring-anti-forgery#2. For some reason, upgrading to 1.7 triggered this middleware on this endpoint only. To remedy, updated /tutorial to a GET, forgoing the nice $.load convenience function and useing $.get. This has the nicety of being more semantically correct anyways. $.load defaults to a GET when no data is given, as in the setupLink function. Upgraded lib-noir to v0.9.9. In versions up to v0.9.8, it fails to start, raising an exception due to an undeclared variable "pretty".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #53. Bump Clojure to the latest stable release, 1.7.0.
The only major switch was avoiding the ring-clojure/ring-anti-forgery 403 permissions error that was being thrown when POST to
/tutorial. The library is included in noir.util.middleware from ring-clojure/ring-defaults. For more information about ring-anti-forgery and POST see ring-clojure/ring-anti-forgery#2. For some reason, upgrading to 1.7 triggered this middleware on this endpoint only.To remedy, updated
/tutorialto a GET, forgoing the nice$.loadconvenience function and using$.get. This has the nicety of being more semantically correct anyways.$.loaddefaults to a GET when no data is given, as in the setupLink function.Upgraded lib-noir to 0.9.9. In versions up to 0.9.8, it fails to start, raising an exception due to an undeclared variable "pretty".