Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tryclj.com to Clojure 1.6 #53

Open
favila opened this issue Feb 2, 2015 · 1 comment
Open

Upgrade tryclj.com to Clojure 1.6 #53

favila opened this issue Feb 2, 2015 · 1 comment

Comments

@favila
Copy link

favila commented Feb 2, 2015

What would it take to upgrade Clojure to 1.6 (currently 1.4)? Update project.clj dependencies? Any other gotchas?

@Raynes
Copy link
Owner

Raynes commented Apr 25, 2015

It'd require clojail work with 1.6. It probably does, but there might be new things needing blacklisted and such. If someone upgrades and it works, I'll take the pull request.

mshenfield added a commit to mshenfield/tryclojure that referenced this issue Jan 20, 2016
Close Raynes#53. Bump Clojure to the latest stable release, 1.7.0.

The only major switch was avoiding the ring-clojure/ring-anti-forgery
403 permissions error that was being thrown when POST to /tutorial. The library is included
in noir.util.middleware from ring-clojure/ring-defaults. For more information
about ring-anti-forgery and POST see ring-clojure/ring-anti-forgery#2.
For some reason, upgrading to 1.7 triggered this middleware on this endpoint only.

To remedy, updated /tutorial to a GET, forgoing the nice $.load convenience
function and useing $.get. This has the nicety of being more semantically correct anyways.
$.load defaults to a GET when no data is given, as in the setupLink function.

Upgraded lib-noir to v0.9.9. In versions up to v0.9.8, it fails to start,
raising an exception due to an undeclared variable "pretty".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants