Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing developer build on clang >=15 #164

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Fixing developer build on clang >=15 #164

merged 4 commits into from
Mar 9, 2023

Conversation

rptb1
Copy link
Member

@rptb1 rptb1 commented Feb 21, 2023

Fixes #163 .

@rptb1 rptb1 self-assigned this Feb 21, 2023
@rptb1 rptb1 added arch.a6 Relates to arm64/aarch64 build Problems with builds and build automation labels Feb 21, 2023
@rptb1 rptb1 changed the title Fixing developer build on Fairphone 3 with Termux (LIA6LL variant) Fixing developer build on Fairphone 3 with Termux (a variant of platform LIA6LL) Feb 22, 2023
@waywardmonkeys
Copy link
Contributor

These warnings break the WebAssembly (#175) build as well since that also uses a newer version of clang.

@rptb1
Copy link
Member Author

rptb1 commented Feb 26, 2023

I can confirm that this branch is required for clang-15 and clang-16 and clang-17. Can be checked with e.g. make -C code -f lii6ll.gmk CC=clang-15 VARIETY=hot clean lii6ll/hot/mps.o

@rptb1 rptb1 added essential Will cause failure to meet customer requirements. Assign resources. and removed arch.a6 Relates to arm64/aarch64 labels Feb 26, 2023
@rptb1 rptb1 changed the title Fixing developer build on Fairphone 3 with Termux (a variant of platform LIA6LL) Fixing developer build on clang >=15 Feb 26, 2023
@rptb1 rptb1 requested review from thejayps and UNAA008 February 26, 2023 02:24
@rptb1 rptb1 marked this pull request as ready for review February 26, 2023 02:24
@rptb1 rptb1 added the low risk This work is or would be of low risk of introducing defects. label Feb 26, 2023
@rptb1
Copy link
Member Author

rptb1 commented Mar 8, 2023

This branch is required by #145 . See https://github.com/Ravenbrook/mps/pull/145/checks?check_run_id=11847545950 .

@rptb1
Copy link
Member Author

rptb1 commented Mar 8, 2023

@waywardmonkeys says in keybase://chat/rptb1,bmitchener/530 :

Great, 164 is most annoying as I have to keep modifying things to let it build :)

@rptb1
Declaring variable as static volatile to ensure clean communication w…
4f5f119 
…ith debugger and suppress warnings. This is a better expression of intention.
rptb1
rptb1 commented Mar 9, 2023
View reviewed changes
Copy link
Member Author

@rptb1 rptb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing proc.review.check

  1. Start time 11:12
  2. Checked compilation with clang-15 with make -C code -f lii6ll.gmk CC=clang-15 VARIETY=hot clean testci. All passed.

code/amcss.c Outdated Show resolved Hide resolved
code/poolawl.c Show resolved Hide resolved
UNAA008
UNAA008 reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@UNAA008 UNAA008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changed files in the context of Issue #163 and am satisfied that the changes are correct.
There would not have been time to review the whole files in an express review.
No defects found.

@rptb1
Copy link
Member Author

rptb1 commented Mar 9, 2023

Executing proc.review.express

  1. Start time 10:47
  2. We'll be applying rule.generic and rule.code
  3. Im. entry.universal shouldn't demand reviews of issues.
  4. Called in @UNAA008
  5. Paused 10:50 while waiting for @UNAA008
  6. Resume 11:07.
  7. Checking started 11:12 for 10 mins.
  8. Logging meeting started at 11:22.
  9. Im. @UNAA008 asks that the interdiction on checking using diffs makes it clear that you're not expected to check all of the file as changed.
  10. @UNAA008 found nothing. @rptb1 found 1 minor defect and 1 question.
  11. proc.review.express.brainstorm: @rptb1 I could've used git blame when I was making the change to add an appropriate comment.
  12. Logging ends 11:30.
  13. Estimated defects remaning: 0
  14. Revised change passed.
  15. review.exit.calc:
  • hours used: 1
  • hours saved: not a lot
  • major defect remaining: 0

@rptb1 rptb1 merged commit 8635e90 into master Mar 9, 2023
@rptb1
Copy link
Member Author

rptb1 commented Mar 9, 2023 •
edited
Loading

Executing proc.merge.pull-request

  1. Start time 11:37
  2. The compiler is the automated test for this.
  3. Waiting for CI to pass until 11:50. Discussed Ghostbusters.
  4. Merge took 7 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UNAA008 UNAA008 UNAA008 left review comments

@thejayps thejayps Awaiting requested review from thejayps

Assignees

@rptb1 rptb1

Labels
build Problems with builds and build automation essential Will cause failure to meet customer requirements. Assign resources. low risk This work is or would be of low risk of introducing defects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPS fails developer build on clang 15
3 participants
@rptb1 @waywardmonkeys @UNAA008