Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of GitHub CI #107

Merged
merged 39 commits into from
Jan 16, 2023
Merged

Make use of GitHub CI #107

merged 39 commits into from
Jan 16, 2023

Conversation

rptb1
Copy link
Member

@rptb1 rptb1 commented Jan 11, 2023 •
edited
Loading

Implementing use of GitHub CI in parallel with Travis CI to help with #109 .

Maintaining both helps with #98 (comment)

I suggest reviewing and merging #104 to master before this, because it's included.

rptb1 added 12 commits January 11, 2023 09:40
@rptb1
Adding a GitHub workflow to trigger a GitHub CI build, as an experiment.
1043d42
@rptb1
Disabling Travis CI on this branch while experimenting with GitHub CI.
f7e3de4
@rptb1
Possibly removing condition that the workflow only works on the defau…
598ca3e 
…lt (master) branch.
@rptb1
Fixing YAML syntax.
0e5a067
@rptb1
Merge branch branch/2023-01-06/gcc-11.3.0-warnings into branch/2023-0…
0770296 
…1-11/github-ci because these warnings cause GitHub CI to fail <https://github.com/Ravenbrook/mps/actions/runs/3892932541/jobs/6644932572#step:4:215>.
@rptb1
Extending job to run on macOS using a build matrix.
46bf2f7
@rptb1
Using the matrix output as input to the job's runs-on parameter.
5561cdf
@rptb1
Adding a Windows build to GitHub CI.
6d3fc4b
@rptb1
Visual Studio tools aren't in CMD in GitHub CI by default. Try using …
d6b1347 
…the shim we made for Travis CI.
@rptb1
Trying a path to Visual Studio environment documented by GitHub <http…
1f65c8b 
…s://github.com/actions/runner-images/blob/e6fcf60b8e6c0f80a065327eaefe836881c28b68/images/win/Windows2022-Readme.md?plain=1#L215>.
@rptb1
Quoting path to Visual Studio environment to try to get CMD to run it…
a538a5e 
… in GitHub CI.
@rptb1
GitHub CI's CMD exited right after the first line, so perhaps the run…
36eea75 
… script is secretly a batch file and needs to use "call".
@rptb1 rptb1 added the build Problems with builds and build automation label Jan 11, 2023
@rptb1 rptb1 mentioned this pull request Jan 11, 2023
Open
@rptb1 rptb1 changed the title Experimenting with GitHub CI Make use of GitHub CI Jan 13, 2023
@rptb1 rptb1 linked an issue Jan 13, 2023 that may be closed by this pull request
MPS CI relies on slow and expensive Travis CI #109
Open
@rptb1 rptb1 marked this pull request as ready for review January 14, 2023 10:30
@rptb1 rptb1 requested review from thejayps and UNAA008 January 14, 2023 10:30
@rptb1 rptb1 added the git-migration Project migration from Ravenbrook internal Perforce infrastructure to public git repo label Jan 14, 2023
rptb1 added 9 commits January 15, 2023 13:17
@rptb1
Adding TODO note about kicking off other CI actions.
6bf2447
@rptb1
Adding explicit build for LII6LL.
b420b85
@rptb1
Attempt to persuade the build matrix to use environment dimension to …
44378f1 
…persuade configure script to use Clang.
@rptb1
Second attempt to include environment in the build matrix.
528e67d
@rptb1
Third attempt to use environment variables to select the compiler.
f809296
@rptb1
Fourth attempt to use environment variables to select the compiler.
2aeee8f
@rptb1
Attempt to add custom dimension to the build matrix to simplify and e…
086eca6 
…xclude XC*GC correctly.
@rptb1
Tidying up and cross-referencing the Travis CI config for missing pla…
559c065 
…tforms.
@rptb1
Discovered that design.mps.test is not referenced from the CI configs…
6a97cbf 
… and is now inconsistent with them. Cross-referenced, added FIXME notes to update documentation.
@rptb1 rptb1 marked this pull request as draft January 15, 2023 14:48
@rptb1
Copy link
Member Author

rptb1 commented Jan 15, 2023 •
edited
Loading

Reverted to draft while I update and cross-reference design.mps.tests.ci.

@rptb1 rptb1 added the optional Will cause failures / of benefit. Worth assigning resources. label Jan 15, 2023
@rptb1 rptb1 added this to the Perforce Polarity milestone Jan 16, 2023
@rptb1 rptb1 marked this pull request as ready for review January 16, 2023 14:11
thejayps
thejayps reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@thejayps thejayps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are doing a "review lite" as suggested by @rptb1.

Review paused to merge pull request #92

.github/workflows/build-and-test.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
code/poolams.c Outdated Show resolved Hide resolved
@rptb1
Catch-up merge with master into branch/2023-01-11/github-ci to elimin…
f507e55 
…ate irrelevant differences from branch/2023-01-06/gcc-11.3.0-warnings from code review.
thejayps
thejayps approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@thejayps thejayps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after merge of #92 (also see #114)

@rptb1
Copy link
Member Author

rptb1 commented Jan 16, 2023

Executing pull request merge procedure.

Checklist results

  1. A nice meta-thing is that the Check results above not only show that the branch builds, but that it solves the problem as well!

  2. An automated test case for this is impractical because it would require demonstrating that Travis was slower on branches in Git.

  3. This branch introduces one file under the MIT licence, which is totally compatible with the MPS BSD licence but illustrates how the MPS must cope with licensed material.

  4. Not quite. The Travis build is queued up for at least an hour because of the very problem that this branch solves. So we're going to go ahead (since there are no actual MPS code changes). We're overriding the procedure in this case.

@rptb1 rptb1 merged commit 3c62e29 into master Jan 16, 2023
@rptb1 rptb1 mentioned this pull request Jan 25, 2023
Merged
@thejayps thejayps mentioned this pull request Feb 13, 2023
Closed
rptb1 added a commit that referenced this pull request Mar 8, 2023
@rptb1
Merging branch/2023-01-11/github-ci for GitHub pull request 107 <#107>.
79c7dc6 
(cherry picked from commit 3c62e29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejayps thejayps thejayps approved these changes

@UNAA008 UNAA008 Awaiting requested review from UNAA008

Assignees
No one assigned
Labels
build Problems with builds and build automation git-migration Project migration from Ravenbrook internal Perforce infrastructure to public git repo optional Will cause failures / of benefit. Worth assigning resources.
Projects
None yet
Milestone
Perforce Polarity
Development

Successfully merging this pull request may close these issues.

MPS CI relies on slow and expensive Travis CI
2 participants
@rptb1 @thejayps