Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for SSID's containing a single quote #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sibert
Copy link

@Sibert Sibert commented Sep 26, 2022

SSID's are allowed to contain single quotes ('). This change allows the configurator to work with SSID's (and passphrases) to contain single quotes. Previous version causes following behavior:

SSID: It's a great network name
Pass: RatOSIsGreat

$ wpa_passphrase 'It's a great network name' 'RatOSIsGreat'

This won't work, so it should be

$ wpa_passphrase "It's a great network name" "RatOSIsGreat"

hence this change

SSID's are allowed to contain single quotes ('). This change allows the configurator to work with SSID's (and passphrases) to contain single quotes.
Previous version causes following behavior:
SSID: It's a great network name
Pass: RatOSIsGreat

$ wpa_passphrase 'It's a great network name' 'RatOSIsGreat'

This won't work, so it should be 

$ wpa_passphrase "It's a great network name" "RatOSIsGreat"

hence this change
@miklschmidt
Copy link
Member

Thanks!

I think a better solution is to use spawn instead of exec, we don't need to quote or escape the arguments that way (but the process can be orphaned, although that seems like an OK tradeoff here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants