Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VoiceClient.wait_until_done #9842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

imayhaveborkedit
Copy link
Contributor

Summary

Adds a new function: VoiceClient.wait_until_done. As the name suggests, it waits until the player is done, similar to the other wait_until_ functions.

There are probably some places in the docs this could be mentioned but i'll add another commit for that later.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Adds a new function: `VoiceClient.wait_until_done`.  As the name
suggests, it waits until the player is done, similar to the other
`wait_until_` functions.
@GnomedDev
Copy link
Contributor

Previously when this was asked for as a part of VoiceClient.play, it was turned down for performance reasons. Since this affects all code paths, not just when wait_until_done is called, how are those performance issues mitigated?

Source: https://discord.com/channels/336642139381301249/336642776609456130/958395836751020032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants