[Guide] Embeds guide #9708
Open
[Guide] Embeds guide #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ika2kki
suggested changes
Jan 13, 2024
There was a problem hiding this comment.
review~
some general feedback pertaining to the whole guide:
overall, i think the structure and flow of the guide could improve a lot. i dont like how each field is introduced individually. i feel the guide should go over the basics:
- passing fields to the constructor
- alternatively using the setters
set_xandadd_field- nuances like attaching a file, library casting to
str - a restrictions and limits section
- recipes with some cool looking embeds and a tip about ZWS
and then leave room for readers to experiment with other fields themselves.
i feel theres also way too many screenshots
i wanted to touch on a few other stuff as well but im a bit tired for now.
thanks for your work, feel free to ignore any advice etc. etc.
IAmTomahawkx
suggested changes
Jan 15, 2024
Co-Authored-By: Tom <[email protected]>
AbstractUmbra
suggested changes
Jan 28, 2024
No767
reviewed
Feb 7, 2024
| ~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Each field has its own character limit. Unfortunately, listing all the limits here would quickly become | ||
| outdated, but you can find them in the :ddocs:`Discord API documentation<resources/channel#embed-object>`. |
There was a problem hiding this comment.
Suggested change
| outdated, but you can find them in the :ddocs:`Discord API documentation<resources/channel#embed-object>`. | |
| outdated, but you can find them in the :ddocs:`Discord API documentation<resources/channel#embed-object-embed-limits>`. |
The link supplied isn't the correct one as you would need to scroll down further, but this one should be the correct one: https://discord.com/developers/docs/resources/channel#embed-object-embed-limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(This is continued from NCPlayz's PR at #7498)
Embeds guide.
Checklist