Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set voice channel status endpoint #9603

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

codeofandrin
Copy link
Contributor

@codeofandrin codeofandrin commented Oct 7, 2023

Summary

This PR adds a new parameter status to VoiceChannel.edit to set the voice channel status via the endpoint /channels/{channel_id}/voice-status

Note: The implementation of the events and permission is seperated into a second PR (#9604) because it can already be merged, which this PR cannot due to the experiment lock.

Related PR: discord/discord-api-docs#6400

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@codeofandrin codeofandrin changed the title Add voice channel status endpoint Add set voice channel status endpoint Oct 7, 2023
@Rapptz
Copy link
Owner

Rapptz commented Oct 7, 2023

This is missing the gateway events and permissions.

@codeofandrin
Copy link
Contributor Author

Yes, I'll create a second PR for it that can already be merged, which this one can't because of the experiment lock.

@codeofandrin
Copy link
Contributor Author

This is now supported by bots:
image

image

@codeofandrin codeofandrin marked this pull request as ready for review December 26, 2023 10:18
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Rapptz Rapptz merged commit 9ce7333 into Rapptz:master Dec 26, 2023
8 checks passed
@codeofandrin codeofandrin deleted the voice-status-endpoint branch May 17, 2024 10:41
@ferrenza
Copy link

It needs to be updated again to ensure that its functionality is truly perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants