Fix race condition with set_result #10020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR was tested by the user experiencing the issue over in the help channel, with a confirmation this fixed it for them here This might only be possible for uvloop users, I'm not 100% sure, but uvloop and asyncio have slightly different internal behavior of the behavior of loop.call_soon/call_later; see ordering difference here: MagicStack/uvloop#482 (comment) This isn't uvloop violating something it must uphold, but it's interesting how internal details like this can end up relied upon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Intended to fix issue raised here: https://discord.com/channels/336642139381301249/1308172568771035186/1308447328478302269
Checklist