Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public method to get session start limits #10007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikeshardmind
Copy link
Contributor

Summary

This adds a method to get session start limits, intended to make it easier for people to use before_identify_hook without needing to override internals or manually make this request.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@mikeshardmind
Copy link
Contributor Author

mikeshardmind commented Nov 10, 2024

Force push to fix docs, forgot this wasn't picked up automatically with how the current layout is for modules

Then forced again because sphinx was being picky about underline length

mikeshardmind added a commit to mikeshardmind/discord.py that referenced this pull request Nov 11, 2024
- Only takes effect when discord provides an increased max concurrency,
  user has not indicated clustering at all, and before_identify_hook has
  not been overriden

  This partially addresses Rapptz#8430

  This depends on a smaller change in Rapptz#10007

  I cannot personally test this change.
mikeshardmind added a commit to mikeshardmind/discord.py that referenced this pull request Nov 11, 2024
- Only takes effect when discord provides an increased max concurrency,
  user has not indicated clustering at all, and before_identify_hook has
  not been overriden

  This partially addresses Rapptz#8430

  This depends on a smaller change in Rapptz#10007

  I cannot personally test this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant