make MobManager#removeMob act on sourceRoom #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this and verified that it is needed. Without this PR, respawn logic gets buggy. |
|
This works great, thanks! |
azigler
added a commit
to azigler/core
that referenced
this pull request
Jun 7, 2020
- improve docstrings - use RanvierMUD#74, RanvierMUD#93, RanvierMUD#98, RanvierMUD#100, RanvierMUD#103, RanvierMUD#106, RanvierMUD#109, RanvierMUD#117, RanvierMUD#104, RanvierMUD#119, RanvierMUD#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the room-specific logic in MobManager#removeMob should act on the mob's source room (as set by Room#spawnNpc), instead of its current room. Otherwise, the mob is never removed from its source room's
spawnedNpcsset, (and possibly the relevant Area'snpcset) if it is removed while in any room other than its source.