-
Notifications
You must be signed in to change notification settings - Fork 269
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cute_tiled: Use uint32_t for hex color values (#364)
Co-authored-by: RandyGaul <[email protected]>
- Loading branch information
Showing
1 changed file
with
20 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
613c978
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this commit is breaking
cute_tiled_read_hex_int_internal
which seems to expect anint*
but is receiving auint32_t*
Edit: The call to that function seems to happen via the macro
cute_tiled_read_hex_int
Lines 2208 and 2214 are where the errors show up for me compiling with MSVC C++17613c978
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there was a merge conflict — looks like I chose the wrong type. Should it be uint32_t? PR would be very helpful — I’m away from computer for the evening
613c978
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put up a PR in order to fix this #375