batch enumerator optimization #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,7 +238,7 @@ module ActiveRecord | |||
| ) | |||
|
|
|||
| expect { | |||
| repository.read(specification.in_batches.result).to_a | |||
| repository.read(specification.in_batches(3).result).to_a | |||
There was a problem hiding this comment.
Seems like you wanted an additional test with non-default batch size
no need to fetch next batch if the previous one is smaller than specified batch size
pjurewicz
force-pushed
the
batch_reading_optimization
branch
from
03ecd61 to
6cfa14f
Compare
WHERE clause is present in the 2nd query the first query do not need any condition
pjurewicz
force-pushed
the
batch_reading_optimization
branch
from
a72a3f6 to
a9fad6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to fetch next batch if the previous one is smaller than specified batch size
(related to #1708)