Fix time promotions bug #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for ecommerce-events failed.
|
haiderRizvii
approved these changes
Sep 9, 2024
andrzejkrzywda
requested changes
Sep 12, 2024
| @@ -45,9 +45,8 @@ def initialize(start_time, end_time, discount) | |||
| end | |||
|
|
|||
| def running?(timestamp) | |||
| (@start_time...@end_time).include?(timestamp) | |||
| (@start_time...@end_time).cover?(timestamp) | |||
There was a problem hiding this comment.
The fix looks perfect.
Apparently, the previous tests didn't catch this problem. Let's add tests as part of this change/fix.
There was a problem hiding this comment.
Added, thank you! 👍
marlena-b
force-pushed
the
fix-time-promotion-bug
branch
from
df26d62 to
e2cd710
Compare
marlena-b
force-pushed
the
fix-time-promotion-bug
branch
from
e2cd710 to
85466a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #386
include?cannot be used with time ranges so i usedcover?.