Fix expiring order

Expiring an order should increase product stock level. The reason is that the order haven't been paid and the stock will not be send. Co-authored-by: Tomasz Stolarczyk <[email protected]>
RailsEventStore · Sep 24, 2024 · e2dba6a · e2dba6a
1 parent 437ea12
commit e2dba6a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/rails_application/app/controllers/orders_controller.rb b/rails_application/app/controllers/orders_controller.rb
@@ -111,7 +111,13 @@ def create
   def expire
     Order
       .where(status: "Draft")
-      .find_each { |order| order.status = "Expired"; order.save! }
+      .find_each do |order|
+      order.order_items.each do |item|
+        item.product.increment!(:stock_level)
+      end
+      order.status = "Expired"
+      order.save!
+    end
     redirect_to root_path
   end
 

diff --git a/rails_application/test/integration/orders_test.rb b/rails_application/test/integration/orders_test.rb
@@ -74,7 +74,11 @@ def test_expiring_orders
     post "/orders/#{order_id}/add_item?product_id=#{async_remote_id}"
     get "/orders"
     assert_select("td", "Draft")
-    post "/orders/expire"
+
+    assert_changes -> { Product.find(async_remote_id).stock_level }, from: 9, to: 10 do
+      post "/orders/expire"
+    end
+
     follow_redirect!
     assert_select("td", "Expired")
   end