Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled and fixed SPI for attiny mcu #539

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Enabled and fixed SPI for attiny mcu #539

merged 1 commit into from
Apr 25, 2024

Conversation

tbienko
Copy link
Contributor

@tbienko tbienko commented Apr 25, 2024

SPI was not exposed for attiny mcu by lib.rs so I've added it. Also I've corrected the spi.rs to use Attiny instead Atmega. This was tested using board with atttiny88 and neopixels connected using SPI driver and seems to work fine

Rahix
Rahix approved these changes Apr 25, 2024
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy to think this wasn't tested when it was originally added :D

In any case, thanks a lot for fixing it and also running actual tests to confirm the fix! :)

@Rahix Rahix merged commit 3e36262 into Rahix:main Apr 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbienko @Rahix