fix path with : in the middle grpc-ecosystem#3517 issue

Ragnaroek · Aug 23, 2023 · 63f0310 · 63f0310
1 parent 99f3b38
commit 63f0310
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/protoc-gen-openapiv2/internal/genopenapi/template.go b/protoc-gen-openapiv2/internal/genopenapi/template.go
@@ -987,13 +987,6 @@ pathLoop:
 				jsonBuffer = ""
 			}
 		case '/':
-			if depth == 0 {
-				parts = append(parts, buffer)
-				buffer = ""
-				// Since the stack was empty when we hit the '/' we are done with this
-				// section.
-				continue
-			}
 			buffer += string(char)
 			jsonBuffer += string(char)
 		case ':':

diff --git a/protoc-gen-openapiv2/internal/genopenapi/template_test.go b/protoc-gen-openapiv2/internal/genopenapi/template_test.go
@@ -3918,6 +3918,7 @@ func TestTemplateToOpenAPIPath(t *testing.T) {
 		{"/{user.name=prefix/*}:customMethod", "/{user.name}:customMethod"},
 		{"/{user.name=prefix1/*/prefix2/*}:customMethod", "/{user.name}:customMethod"},
 		{"/{parent=prefix/*}/children:customMethod", "/{parent}/children:customMethod"},
+		{"/item/search:items/{item_no_query}", "/item/search:items/{item_no_query}"},
 	}
 	reg := descriptor.NewRegistry()
 	reg.SetUseJSONNamesForFields(false)