Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP nested groups patch (Copied from GeoffMaciolek:tkr-ldap-recurse pull #147) #156

Open
wants to merge 1 commit into
base: maintenance-0.20.x
Choose a base branch
from

Conversation

bpothier
Copy link
Contributor

Copied from Pull request from GeoffMaciolek:tkr-ldap-recurse to see if it will merge
I ignored the "changed" lines in auth.php 622-626 and 628, removed blank line 678 from original patch as they appeared the same except likely some whitespace differences?
It now says able to merge...
You can try reverting those lines in @GeoffMaciolek / @trkr1410 's pull request to get it to merge?
Not sure if LDAP allows circular nesting, but I don't think the nested_groups() function checks for that.

Copied from Pull request from GeoffMaciolek:tkr-ldap-recurse to see if it will merge
@fgunger
Copy link

fgunger commented Jan 13, 2020

I see two problems with the proposed code:

  1. There is a risk that LDAP may nest group membership circular and the function should to take this into account. (Needs to add a "max nesting" LDAP parameter or similar with a sane default.)
  2. Groups search filter is also applied prior to checking for nested groups. So if you would set a "app-racktables"-filter, a group called "app-racktables-view" would not be found if the group membership would go though a "datacenter-technicians" group.
    I am afraid I won't have time to make the changes needed at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants