ネームプレートの同期がズレるのを修正した #743
Merged
ネームプレートの同期がズレるのを修正した #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoishin
reviewed
Dec 28, 2023
Comment on lines
14
to
39
| const participantSocials = [ | ||
| ...(currentRun?.runners.map((runner) => | ||
| [ | ||
| runner.twitter ? "twitter" : null, | ||
| runner.twitch ? "twitch" : null, | ||
| runner.nico ? "nico" : null, | ||
| ].filter((v): v is DisplayLabel => v !== null), | ||
| ) ?? []), | ||
| ...(currentRun?.commentators.map((commentator) => | ||
| [ | ||
| commentator?.twitter ? "twitter" : null, | ||
| commentator?.twitch ? "twitch" : null, | ||
| commentator?.nico ? "nico" : null, | ||
| ].filter((v): v is DisplayLabel => v !== null), | ||
| ) ?? []), | ||
| ]; | ||
|
|
||
| const displayTwitter = participantSocials.some((socials) => | ||
| socials.includes("twitter"), | ||
| ); | ||
| const displayTwitch = participantSocials.some((socials) => | ||
| socials.includes("twitch"), | ||
| ); | ||
| const displayNico = participantSocials.some((socials) => | ||
| socials.includes("nico"), | ||
| ); |
There was a problem hiding this comment.
const participants = [
...currentRun?.runners,
...currentRun?.commentators,
];
const displayTwitter = participants.some(p => Boolean(p.twitter))
const displayTwitch = participants.some(p => Boolean(p.twitch))
const displayNico = participants.some(p => Boolean(p.nico))とかでいい感じしますがあってますか
yagamuu
approved these changes
Dec 28, 2023
|
マージされたら#720 はクローズで良さそう？という共有 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ネームプレートごとに gsap のタイムラインが存在するため、 徐々に同期がズレて異なる情報が表示されるようになってしまっていました
SyncDisplayProviderを用意して、どの情報を表示するかを graphics 内で統一した