Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRKBlutspendeBridge] add new bridge #4324

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

User123698745
Copy link
Contributor

This PR adds a new bridge "DRKBlutspendeBridge" for https://www.drk-blutspende.de. Its a site from the DRK = Deutsches Rotes Kreuz (German Red Cross) which provides information about blood donation. It already has a feed for blood donation appointments across germany, but that feed is very bare-bone. This bridge uses FeedExpander to extend the feed with more details.

Copy link

github-actions bot commented Nov 10, 2024

Pull request artifacts

Bridge Context Status
DRKBlutspende 1 Termine (pr) ✔️

last change: Sunday 2024-11-24 01:35:20

@User123698745
Copy link
Contributor Author

@dvikan can this new bridge get merged?

@dvikan
Copy link
Contributor

dvikan commented Nov 24, 2024

yes. but please move explode_lines to class.

@User123698745
Copy link
Contributor Author

Thanks. I moved explode_lines into the DRKBlutspendeBridge class.

Note: The "PR Testing / Upload tests" step failed, because I only moved code and the output stayed the same. That is a bug in the pipeline, which would get fixed once my other PR #4313 gets merged.

@dvikan dvikan merged commit 83bc3fd into RSS-Bridge:master Nov 24, 2024
8 of 9 checks passed
@User123698745 User123698745 deleted the DRKBlutspendeBridge branch November 26, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants