Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prtester.py] tolerate failed termpad.com uploads #4269

Conversation

User123698745
Copy link
Contributor

termpad.com is down for a few hours now (hopefully not permanently). The "Generate HTML" check of any pull requests will fail, because the preview upload would run into a timeout.
In my opinion, termpad.com being down should not cause the pipeline to fail, preventing it from generating the "Pull request artifacts" comment.

This PR will catch the timeout exception, log it and continue. The "Pull request artifacts" comment will look the same including the warnings and errors. Only the "Context" column will not be linked to preview on termpad.com.
Additionally a new argument --termpad-instance gets add, which allows to use a different termpad instance like e.g. termpad.planethawleywood.com.

@dvikan
Copy link
Contributor

dvikan commented Sep 19, 2024

looks good

@Bockiii

@Bockiii
Copy link
Contributor

Bockiii commented Sep 21, 2024

user1234... has reworked the prtester file quite substantially since I created it, so I dont really have an opinion tbh.

I would however suggest to maybe host "our own" instance of pastebin for all the PR tests. You can host one that only allows users to upload something (its the default for pastebin.com for example), so you can create only one user (the pr tester user), have their API key in the repo secrets and use that to host the tests.

This would make sure that we have control over the tests (could be deleted after x months or after PR closure etc), closing registration and only allowing the one user will avoid random people uploading nasty stuff into it etc.

So @dvikan if you have the capacity, maybe setup that and then we reconfigure the prtester to send the tests to that pastebin

@User123698745
Copy link
Contributor Author

The "Generate HTML" check now failed for the first PR !4270 because termpad.com is still down.
Sadly the owner of termpad.com confirmed that its intentionally down and "won't be back anytime soon": SpyrosRoum/termpad#14

@Bockiii
Copy link
Contributor

Bockiii commented Oct 3, 2024

@dvikan are you planning on setting up your own termpad instance or not? If not, instead of changing the code, you could just deactivate the test until someone finds an alternative

@Bockiii
Copy link
Contributor

Bockiii commented Oct 7, 2024

I have a new idea, which makes it even easier:

You can use github to get a github.io website for projects ( https://pages.github.com/ ). We could use this for two things, one would be this (instead of uploading the html files to a pastebin, just add it to the repo that is hosted by github and it will automatically render, see a quick example here: https://bockiii.github.io/prs/1234/before.html ), another would be to show status of current bridges (the bridge-tester that I worked on before, I would pick that thread up again).

Setup of the github.io site should be easy, adding the files is easy (theres a workflow module for it, requires little work) and we will have full control over the files (e.g. remove the files after the PR is closed etc). Win-win for all involved.

@Bockiii
Copy link
Contributor

Bockiii commented Oct 13, 2024

Looks like @dvikan has been afk for a month. @Mynacol do you want to set up said extra repo and github.io url?

If you want, you can add me as a maintainer again and I'll come back to set this up.

@dvikan
Copy link
Contributor

dvikan commented Oct 14, 2024

yes I afk a bit.

i invited you to be maintainer.

feel free to try out your idea @Bockiii

@Bockiii
Copy link
Contributor

Bockiii commented Oct 16, 2024

hey @User123698745 , the test storage has been reworked and should not fail again since we are now relying on github pages instead of termpad. Thanks for the trigger to do this!

@Bockiii Bockiii closed this Oct 16, 2024
@User123698745 User123698745 deleted the tolerate_failed_termpad_uploads branch October 16, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants