Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PriviblurBridge] Add Priviblur (Tumblr frontend) bridge #4221

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

Phantop
Copy link
Contributor

@Phantop Phantop commented Aug 19, 2024

Adds a bridge for Priviblur, as it provides plaintext versions of Tumblr posts. Useful as some Tumblr pages (e.g. page search, non-user tags, tags for users without a subdomain) do not have official RSS feeds and many require either Javascript or an API token (and substantial API usage) to access contents without the assistance of a frontend.

Copy link

github-actions bot commented Aug 19, 2024

Pull request artifacts

Bridge Context Status
Priviblur 1 untitled (pr) ✔️

last change: Wednesday 2024-08-21 20:50:23

@dvikan
Copy link
Contributor

dvikan commented Aug 21, 2024

this fetches the /explore/trending posts on frontpage. not in date order.

the instance might go down. maybe better to allow user to select from a list?

also use latest from master.

[2024-08-21 21:57:56] rssbridge.ERROR Exception in DisplayAction(PriviblurBridge) {
    "type": "ErrorException",
    "code": 0,
    "message": "Attempt to read property \"plaintext\" on null",
    "file": "bridges/PriviblurBridge.php",
    "line": 39,
    "url": "http://127.0.0.1/?action=display&bridge=PriviblurBridge&url=https%3A%2F%2Fpriviblur.fly.dev&format=Html",
    "trace": [
        "index.php(81): RssBridge->main()",
        "lib/RssBridge.php(96): DisplayAction->__invoke()",
        "actions/DisplayAction.php(66): DisplayAction->createResponse()",
        "actions/DisplayAction.php(114): PriviblurBridge->collectData()",
        "bridges/PriviblurBridge.php(39): {closure}()",
        "bridges/PriviblurBridge.php(39)"
    ]
}

@Phantop
Copy link
Contributor Author

Phantop commented Aug 21, 2024

this fetches the /explore/trending posts on frontpage. not in date order.

It's mostly there as an unselective example page, as it follows the format and all entries are timestamped anyways. Should I be reordering the entries in date order despite them having timestamp attributes?

the instance might go down. maybe better to allow user to select from a list?

I think it's preferable to allow the user to openly select which instance they use, rather than writing in a list that might all go down. There's unfortunately no official instance—the instance I used is one I host myself—so it's hard to decide on anything else to put there (hence URI being set to the Github page).

also use latest from master.

What do you mean?

@Phantop
Copy link
Contributor Author

Phantop commented Aug 21, 2024

The error you posted should be fixed! Made the assumption that all Tumblr posts would be tagged.

@dvikan dvikan merged commit 06a8896 into RSS-Bridge:master Aug 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants