Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PatreonBridge] Extend the presentation of parsed posts #3617

Merged
merged 4 commits into from
Aug 29, 2023
Merged

[PatreonBridge] Extend the presentation of parsed posts #3617

merged 4 commits into from
Aug 29, 2023

Conversation

mruac
Copy link
Contributor

@mruac mruac commented Aug 15, 2023

This commit extends the current PatreonBridge feed item presentation to include:

  • All images shown in a patreon post
  • Detects and links to a patreon video post (no direct links available due to HLS)
  • The embed preview in a patreon post
  • An HTML audio player for patreon audio post
  • All poll options for a patreon poll post
  • Hinted filetype of all attached files (image, audio and attachments)
  • A list of attachments with their filenames previewed (separate to the feed item's enclosures)

mruac added 2 commits August 15, 2023 19:40
@mruac
extend post presentation
1f58689
@mruac
applied phpcbf
5e89c7f 
note: phpcs does not like long null coalescing chains
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited
Loading

Pull request artifacts

file last change
PatreonBridge-current-context1 2023-08-24, 10:55:07
PatreonBridge-pr-context1 2023-08-24, 10:55:07

@mruac
Copy link
Contributor Author

mruac commented Aug 15, 2023

The failed phpcs lint is due to the excessively long null coalescing chain ?? - Not sure how to get around that.

@mruac
Copy link
Contributor Author

mruac commented Aug 15, 2023

For Poll post:
Before:
image

After:
image

@mruac
Copy link
Contributor Author

mruac commented Aug 15, 2023

Audio post:
Before:
Screenshot 23-08-15 195911 569

After:
Screenshot 23-08-15 195424 021

@mruac
Copy link
Contributor Author

mruac commented Aug 15, 2023

Image post - A toggle may be needed to trim the number of images rendered? I remember this issue of not extending the Webtoons bridge for this reason.
#2957 (comment)

Before:
Screenshot 23-08-15 200116 913

After:
Screenshot 23-08-15 200407 258

@dvikan
Copy link
Contributor

dvikan commented Aug 15, 2023

conflict

@mruac
Copy link
Contributor Author

mruac commented Aug 16, 2023

resolved

@dvikan
Copy link
Contributor

dvikan commented Aug 22, 2023

lint

@mruac mruac mentioned this pull request Aug 24, 2023
Closed
@mruac
Copy link
Contributor Author

mruac commented Aug 24, 2023

resolved

@dvikan
Copy link
Contributor

dvikan commented Aug 24, 2023

im getting 403 on my local instance. same as here: https://rss-bridge.org/bridge01/?action=display&bridge=PatreonBridge&creator=scottadamssays&format=Html

are u able to use this bridge?

@mruac
Copy link
Contributor Author

mruac commented Aug 24, 2023 •
edited
Loading

Still works in my testing instance.
Wondering if providing the session cookie can get around the 403.

@mruac
Copy link
Contributor Author

mruac commented Aug 24, 2023

It might be a cloudflare issue.

@mruac
Copy link
Contributor Author

mruac commented Aug 29, 2023

im getting 403 on my local instance. same as here: https://rss-bridge.org/bridge01/?action=display&bridge=PatreonBridge&creator=scottadamssays&format=Html

are u able to use this bridge?

Public instance bridge works again.

@dvikan dvikan merged commit 9707586 into RSS-Bridge:master Aug 29, 2023
@dvikan
Copy link
Contributor

dvikan commented Aug 30, 2023

please fix:

[2023-08-30 11:55:25] rssbridge.WARNING Undefined property: stdClass::$thumbnail at bridges/PatreonBridge.php line 149 
[2023-08-30 11:55:25] rssbridge.WARNING Trying to get property 'url' of non-object at bridges/PatreonBridge.php line 149

mruac added a commit to mruac/mruac-rss-bridge that referenced this pull request Aug 31, 2023
@mruac
resolved github comment
f9c7248 
RSS-Bridge#3617
@mruac
Copy link
Contributor Author

mruac commented Aug 31, 2023

Try that - I have got them to null coalesce into null rather than into another property that may not exist.

mruac added a commit to mruac/mruac-rss-bridge that referenced this pull request Aug 31, 2023
@mruac
resolved github comment RSS-Bridge#3617
5cb3038
@mruac mruac mentioned this pull request Sep 11, 2023
Merged
dvikan pushed a commit that referenced this pull request Sep 11, 2023
@mruac
[PatreonBridge] resolve null coalescing issue (#3664)
3e1e96e 
* extend post presentation

* applied phpcbf

note: phpcs does not like long null coalescing chains

* resolved phpcs

* resolved github comment #3617

* .

* lint SteamAppNewsBridge
dvikan pushed a commit to dvikan/rss-bridge that referenced this pull request Sep 13, 2023
@mruac @dvikan
[PatreonBridge] Extend the presentation of parsed posts (RSS-Bridge#3617
3319da0 
)

* extend post presentation

* applied phpcbf

note: phpcs does not like long null coalescing chains

* resolved phpcs
dvikan pushed a commit to dvikan/rss-bridge that referenced this pull request Sep 13, 2023
@mruac @dvikan
[PatreonBridge] resolve null coalescing issue (RSS-Bridge#3664)
9c12a33 
* extend post presentation

* applied phpcbf

note: phpcs does not like long null coalescing chains

* resolved phpcs

* resolved github comment RSS-Bridge#3617

* .

* lint SteamAppNewsBridge
@dvikan
Copy link
Contributor

dvikan commented Sep 21, 2023

please fix:

@mruac

Trying to get property 'url' of non-object at bridges/PatreonBridge.php line 153

mruac added a commit to mruac/mruac-rss-bridge that referenced this pull request Sep 22, 2023
@mruac
resolve comment
ae13866 
RSS-Bridge#3617 (comment)
@mruac mruac mentioned this pull request Sep 22, 2023
Merged
dvikan pushed a commit that referenced this pull request Sep 22, 2023
@mruac
resolve comment (#3683)
a3c29f3 
#3617 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mruac @dvikan