Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vectorized rms_norm support for Navi31 #273

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add vectorized rms_norm support for Navi31 #273

wants to merge 3 commits into from

Conversation

hyoon1
Copy link

@hyoon1 hyoon1 commented Nov 12, 2024 •
edited by github-actions bot
Loading

  • supports vectorized rms_norm_kernel

@maleksan85
Copy link

As per @gshtras we need to merge into develop branch instead of main for now. Please correct.

@gshtras gshtras changed the base branch from main to develop November 13, 2024 18:12
@hyoon1
Copy link
Author

hyoon1 commented Nov 13, 2024

As per @gshtras we need to merge into develop branch instead of main for now. Please correct.

Updated

maleksan85
maleksan85 approved these changes Nov 13, 2024
View reviewed changes
Copy link

@maleksan85 maleksan85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyoon1
Add vectorized rms_norm support for Navi31
0379295 
- supports vectorized rms_norm_kernel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleksan85 maleksan85 maleksan85 approved these changes

@gshtras gshtras Awaiting requested review from gshtras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyoon1 @maleksan85