Update on naive_attn module #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix, https://ontrack-internal.amd.com/browse/SWDEV-469079 CP https://github.com/ROCm/vllm/pull/16/files to perf_benchmark_navi branch
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Fixed some syntax errors in use_naive_attn module in rocm_flash_attn.py
Also, allowed navi3x to use use_triton_flash_attn.
https://github.com/ROCm/vllm/blob/perf_benchmark_navi/vllm/attention/backends/rocm_flash_attn.py
https://github.com/ROCm/vllm/blob/perf_benchmark_navi/vllm/attention/ops/triton_flash_attention.py
Regards,
Seungrok