RPP Warp Perspective on HOST and HIP #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Sep 18, 2024
•
r-abishek
commented
- Updates version to RPP 1.9.6
- Adds tensor implementation for Warp Perspective on HOST and HIP
- Adds support for U8/F16/F32/I8 bit-depths with NHWC/NCHW and layout toggle support
- Adds relevant unit/perf tests
…k/rpp into opt_warp_perspective_rebased
Rebased version of warp perspective
rrawther
requested changes
Nov 6, 2024
| bool kernelSizeCase = (testCase == 49); | ||
| bool dualInputCase = (testCase == 2 || testCase == 30 || testCase == 33 || testCase == 61 || testCase == 63 || testCase == 65 || testCase == 68); | ||
| bool randomOutputCase = (testCase == 6 || testCase == 8 || testCase == 84); | ||
| bool nonQACase = (testCase == 24); | ||
| bool interpolationTypeCase = (testCase == 21 || testCase == 23 || testCase == 24 || testCase == 79); | ||
| bool nonQACase = (testCase == 24 || testCase == 28); |
There was a problem hiding this comment.
why this is added to nonQA
There was a problem hiding this comment.
Warp Affine and Perspective alone have some very minor precision related differences that don't match exactly. We's spent considerable cycles trying to match that minor difference, but its something to do with the _mm256_setr_ps instruction on computed float location indexes that differs from rawC. @HazarathKumarM You can put the sertr vs rawC values here.
There was a problem hiding this comment.
I am confused. Is this going to be fixed?
rrawther
approved these changes
Nov 20, 2024
LakshmiKumar23
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.