Install the LICENSE file to ${CMAKE_INSTALL_DOCDIR} #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie., {INSTALL_PREFIX}/share/doc/omnitrace/LICENSE
Internal ticket: SWDEV-466385
Signed-off-by: David Galiffi <[email protected]>
|
A missing requirement from dev-ops / packaging. |
nunnikri
reviewed
Sep 4, 2024
| ${PROJECT_SOURCE_DIR}/LICENSE | ||
| DESTINATION ${CMAKE_INSTALL_DOCDIR} | ||
| COMPONENT setup) | ||
|
|
There was a problem hiding this comment.
I think these 2 lines are also required along with the above changes.
set ( CPACK_RESOURCE_FILE_LICENSE ${PROJECT_SOURCE_DIR}/LICENSE )
set ( CPACK_RPM_PACKAGE_LICENSE "MIT" )
There was a problem hiding this comment.
Thanks, @nunnikri .
CPACK_RESOURCE_FILE_LICENSE is already set in cmake/ConfigCPack.cmake, but I added CPACK_RPM_PACKAGE_LICENSE.
Signed-off-by: David Galiffi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ie., {INSTALL_PREFIX}/share/doc/omnitrace/LICENSE
Internal ticket: SWDEV-466385