Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl adaptive avgpool #3301

Open
wants to merge 47 commits into
base: develop
Choose a base branch
from
Open

Impl adaptive avgpool #3301

wants to merge 47 commits into from
+3,661 −2

Conversation

hieule88
Copy link
Collaborator

@hieule88 hieule88 commented Oct 7, 2024 •
edited
Loading

  • Added AdaptiveAvgPool 1D 2D 3D forward and backward.

  • Added driver test and gtest for AdaptiveAvgPool .

  • New API is guarded by MIOPEN_BETA_API macro.

  • Full benchmark here: link

  • Average over all cases:

  • AdaptiveAvgPool 1D

Type Forward Backward
float16 2.26 1.94
float32 2.01 1.97
bfloat16 2.25 1.97
  • AdaptiveAvgPool 2D
Type Forward Backward
float16 4.48 1.38
float32 3.15 1.31
bfloat16 3.65 1.39
  • AdaptiveAvgPool 3D
Type Forward Backward
float16 2.14 1.72
float32 2.03 2.06
bfloat16 2.13 1.71

@hieule88
init
d197108
@hieule88
skeleton code
3c90908
@hieule88
add solver, kernel
86a5073
@hieule88
add gtest
ca4ad97
@hieule88
add driver test
0492fc7
@hieule88
change kinfor to ksize
881e796
@hieule88
change params
3612897
@hieule88
fix gtest
930d47e
@hieule88
passed gtest
5a35738
@hieule88
skeleton code
27470a2
@hieule88
small fix
2e131c7
@hieule88
Merge remote-tracking branch 'origin/develop-moreh' into impl_adaptiv…
0e773fa 
…e_avgpool
@hieule88
add isOverRocm3d
7d3a0a6
@hieule88
add const Tgpu
dfbb6c7
@hieule88
add resolve comment Rocm PR
88179b0
@hieule88
add issametype
d2b2d1f
@hieule88
rm ENV gtest
0dc61de
@hieule88
rm magic number in driver test
194ab40
@hieule88
change to AddTensorFlag
36b0662
@hieule88
small fix
99ff4bb
@hieule88
fix driver as comments
42b54a7
@hieule88
for to parford
22ae98a
@hieule88
resolved comments
6ef45f6
@hieule88
rm large number of cast in kernel
796adb1
@hieule88
resolved comments
93985d4
@hieule88
add T
7795a19
@hieule88
Merge remote-tracking branch 'upstream/develop' into impl_adaptive_av…
cde0f8b 
…gpool
@hieule88
Merge remote-tracking branch 'upstream/develop' into impl_adaptive_av…
eabac2a 
…gpool
@hieule88
reorder
58bcf1e
@iq136boy
Copy link
Contributor

iq136boy commented Oct 9, 2024

error log:
3301.txt

@hieule88 hieule88 marked this pull request as ready for review October 15, 2024 08:21
@hieule88 hieule88 self-assigned this Oct 18, 2024
@iq136boy
Copy link
Contributor

CI passed. But the PR still need to solve conflict before it is getting merged.

iq136boy
iq136boy reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@iq136boy iq136boy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error_log:
3301_log.txt

@hieule88
Copy link
Collaborator Author

Error_log: 3301_log.txt

I fixed this error. Please send me the newest error log of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iq136boy iq136boy iq136boy left review comments

@JehandadKhan JehandadKhan Awaiting requested review from JehandadKhan

@junliume junliume Awaiting requested review from junliume junliume is a code owner

@BrianHarrisonAMD BrianHarrisonAMD Awaiting requested review from BrianHarrisonAMD BrianHarrisonAMD is a code owner

@BradPepersAMD BradPepersAMD Awaiting requested review from BradPepersAMD BradPepersAMD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hieule88 hieule88

Labels
enhancement external_collaborator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hieule88 @iq136boy @long10024070