-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Where backward #3295
base: develop
Are you sure you want to change the base?
Implement Where backward #3295
Conversation
@cognaiger9 : Do we need to add any material to the ROCm docs to cover this? |
This operation belongs to the |
@cognaiger9: Oh, in terms of where you added it in reference/index.rst, I think it's fine. I was only wondering if we needed to add extra material to any of the conceptual or how-to documents? (Maybe I'm not sure what you're referring to by the new material?) |
@amd-jnovotny I think the current docs is sufficient and does not require extra material |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI log:
3295_log.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error_log:
3295_log (2).txt
std::unique_ptr<GPUMem> inGrad_dev = nullptr; | ||
std::unique_ptr<GPUMem> otherGrad_dev = nullptr; | ||
|
||
std::vector<uint8_t> cond; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason of using type uint8_t
for cond
tensor instead of bool
?
Average improvement over ROCm
Detail Benchmark
float16
float32
bfloat16