Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C++ language extensions #3488

Merged
merged 4 commits into from
May 31, 2024
Merged

Update C++ language extensions #3488

merged 4 commits into from
May 31, 2024

Conversation

matyas-streamhpc
Copy link

No description provided.

@matyas-streamhpc matyas-streamhpc self-assigned this May 17, 2024
tomsang
tomsang suggested changes May 17, 2024
View reviewed changes
docs/reference/kernel_language.rst Outdated Show resolved Hide resolved
docs/reference/kernel_language.rst Show resolved Hide resolved
@tomsang
Copy link
Contributor

tomsang commented May 21, 2024

I have a few comments. Please update PR accordingly.

tomsang
tomsang suggested changes May 22, 2024
View reviewed changes
docs/reference/kernel_language.rst Outdated Show resolved Hide resolved
tomsang
tomsang suggested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@tomsang tomsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hipLaunchParm lp, " should be removed here,
// Example hipLaunchKernelGGL pseudocode:
global MyKernel(hipLaunchParm lp, float *A, float *B, float *C, size_t N)
{
...
}

@neon60 neon60 changed the base branch from develop to docs/develop May 28, 2024 12:51
@neon60
Copy link
Contributor

neon60 commented May 28, 2024

@matyas-streamhpc rebased your branch and targeted docs/develop

@neon60 neon60 force-pushed the fix-cpp-language-extensions branch from 964ac00 to d518b3a Compare May 28, 2024 12:52
@matyas-streamhpc
Copy link
Author

matyas-streamhpc commented May 30, 2024 •
edited
Loading

"hipLaunchParm lp, " should be removed here, // Example hipLaunchKernelGGL pseudocode: global MyKernel(hipLaunchParm lp, float *A, float *B, float *C, size_t N) { ... }

It has been fixed in 3be5ac3
(former d518b3a)

@matyas-streamhpc
Copy link
Author

matyas-streamhpc commented May 30, 2024 •
edited
Loading

@matyas-streamhpc rebased your branch and targeted docs/develop

Rebased again.

@neon60 neon60 requested a review from tomsang May 30, 2024 15:26
@neon60 neon60 merged commit 59de486 into docs/develop May 31, 2024
3 checks passed
@neon60 neon60 deleted the fix-cpp-language-extensions branch June 10, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsang tomsang tomsang approved these changes

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

Assignees

@matyas-streamhpc matyas-streamhpc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matyas-streamhpc @tomsang @neon60