Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cooperative groups #3478

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Add cooperative groups #3478

merged 1 commit into from
Aug 1, 2024

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented May 8, 2024 •
edited
Loading

Add cooperative groups documentation which contains:

  • Reference
  • How to
  • Tutorial

@neon60 neon60 changed the title Add cooperative groups WIP - Add cooperative groups May 8, 2024
@neon60 neon60 marked this pull request as draft May 8, 2024 15:04
@neon60 neon60 force-pushed the cooperative_groups branch 3 times, most recently from a4b794e to 27d3e89 Compare May 13, 2024 13:04
@neon60 neon60 changed the title WIP - Add cooperative groups Add cooperative groups May 13, 2024
@neon60 neon60 marked this pull request as ready for review May 13, 2024 13:05
randyh62
randyh62 reviewed May 13, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have two files in the docs folder named the same, such as how-to/cooperative_groups.rst and reference/cooperative_groups.rst, even though they are currently in separate folders.

I think one should be renamed.

@neon60 neon60 changed the base branch from develop to docs/develop May 14, 2024 15:13
@neon60
Copy link
Contributor Author

neon60 commented May 14, 2024

I don't think we should have two files in the docs folder named the same, such as how-to/cooperative_groups.rst and reference/cooperative_groups.rst, even though they are currently in separate folders.

I think one should be renamed.

Renamed.

@neon60 neon60 force-pushed the cooperative_groups branch from d35ccd3 to f7149f5 Compare May 15, 2024 07:20
@neon60 neon60 force-pushed the cooperative_groups branch from 16b0b05 to 9c36248 Compare May 17, 2024 09:04
@neon60 neon60 force-pushed the cooperative_groups branch from 9c36248 to 799bb8b Compare May 17, 2024 13:54
@neon60 neon60 force-pushed the cooperative_groups branch 4 times, most recently from 0951807 to a1c70e1 Compare July 10, 2024 14:41
@neon60 neon60 force-pushed the cooperative_groups branch 6 times, most recently from 6a92313 to 1d94dbc Compare July 24, 2024 14:06
randyh62
randyh62 approved these changes Jul 29, 2024
View reviewed changes
docs/tutorial/cooperative_groups_tutorial.rst Outdated Show resolved Hide resolved
docs/understand/programming_model_reference.rst Outdated Show resolved Hide resolved
docs/understand/programming_model_reference.rst Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Outdated Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Outdated Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Outdated Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Outdated Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Outdated Show resolved Hide resolved
@neon60 neon60 force-pushed the cooperative_groups branch 8 times, most recently from 2376afd to 87d9b0a Compare July 31, 2024 07:07
b-sumner
b-sumner reviewed Jul 31, 2024
View reviewed changes
docs/how-to/cooperative_groups.rst Outdated Show resolved Hide resolved
docs/how-to/cooperative_groups.rst Outdated Show resolved Hide resolved
b-sumner
b-sumner reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@b-sumner b-sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good now.

docs/reference/cpp_language_extensions.rst Show resolved Hide resolved
@neon60 neon60 force-pushed the cooperative_groups branch from aebe53b to 5c4d394 Compare August 1, 2024 16:48
randyh62
randyh62 approved these changes Aug 1, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided feedback in Teams

@neon60 neon60 force-pushed the cooperative_groups branch from 5c4d394 to c0fcdaf Compare August 1, 2024 17:15
@neon60 neon60 force-pushed the cooperative_groups branch from c0fcdaf to 02cc700 Compare August 1, 2024 17:16
@neon60 neon60 merged commit 955c344 into docs/develop Aug 1, 2024
4 checks passed
@neon60 neon60 deleted the cooperative_groups branch August 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpaoletti lpaoletti lpaoletti left review comments

@parbenc parbenc parbenc approved these changes

@matyas-streamhpc matyas-streamhpc matyas-streamhpc left review comments

@b-sumner b-sumner b-sumner left review comments

@randyh62 randyh62 randyh62 approved these changes

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@neon60 @b-sumner @randyh62 @matyas-streamhpc @parbenc @lpaoletti