Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run hip gemm pointwise fusion for quant_dot #3702

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ahsan-ca
Copy link
Contributor

@ahsan-ca ahsan-ca commented Dec 11, 2024

This PR makes change to ensure that hip gemm pointwise fusion
is performed for dot, and not for quant_dot.

@ahsan-ca ahsan-ca added the bugfix Fixes a bug found in the code. label Dec 11, 2024
@ahsan-ca ahsan-ca self-assigned this Dec 11, 2024
@ahsan-ca ahsan-ca requested a review from causten as a code owner December 11, 2024 03:23
@ahsan-ca ahsan-ca changed the title Do not run hip gemm pointwise fusion for hip_quant_gemm Do not run hip gemm pointwise fusion for quant_dot Dec 11, 2024
@ahsan-ca ahsan-ca force-pushed the hipblaslt-gemm-pointwise-update branch from 0a711d4 to 567c4a6 Compare December 11, 2024 03:59
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (2e59073) to head (567c4a6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3702   +/-   ##
========================================
  Coverage    92.23%   92.23%           
========================================
  Files          514      514           
  Lines        21746    21746           
========================================
  Hits         20057    20057           
  Misses        1689     1689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
567c4a
Rate old
64fe0c
Diff Compare
torchvision-resnet50 64 3,256.04 3,254.94 0.03%
torchvision-resnet50_fp16 64 6,989.29 6,977.96 0.16%
torchvision-densenet121 32 2,435.79 2,436.55 -0.03%
torchvision-densenet121_fp16 32 4,044.49 4,076.26 -0.78%
torchvision-inceptionv3 32 1,627.34 1,627.46 -0.01%
torchvision-inceptionv3_fp16 32 2,743.15 2,741.58 0.06%
cadene-inceptionv4 16 764.85 764.31 0.07%
cadene-resnext64x4 16 813.71 813.14 0.07%
slim-mobilenet 64 7,470.82 7,466.83 0.05%
slim-nasnetalarge 64 209.08 209.03 0.03%
slim-resnet50v2 64 3,440.88 3,443.32 -0.07%
bert-mrpc-onnx 8 1,147.99 1,144.17 0.33%
bert-mrpc-tf 1 484.60 474.21 2.19%
pytorch-examples-wlang-gru 1 421.57 416.53 1.21%
pytorch-examples-wlang-lstm 1 403.21 384.23 4.94% 🔆
torchvision-resnet50_1 1 768.62 783.29 -1.87%
cadene-dpn92_1 1 400.45 398.94 0.38%
cadene-resnext101_1 1 382.85 383.46 -0.16%
onnx-taau-downsample 1 345.62 345.52 0.03%
dlrm-criteoterabyte 1 33.33 33.33 0.01%
dlrm-criteoterabyte_fp16 1 52.73 52.73 -0.01%
agentmodel 1 8,141.53 8,127.83 0.17%
unet_fp16 2 58.76 58.89 -0.21%
resnet50v1_fp16 1 1,058.42 938.63 12.76% 🔆
resnet50v1_int8 1 1,009.30 984.73 2.50%
bert_base_cased_fp16 64 1,168.81 1,170.23 -0.12%
bert_large_uncased_fp16 32 363.00 362.94 0.02%
bert_large_fp16 1 200.22 200.28 -0.03%
distilgpt2_fp16 16 2,199.43 2,198.50 0.04%
yolov5s 1 531.57 531.33 0.05%
tinyllama 1 43.64 43.34 0.68%
vicuna-fastchat 1 174.38 172.03 1.37%
whisper-tiny-encoder 1 417.58 418.00 -0.10%
whisper-tiny-decoder 1 429.18 428.83 0.08%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants