Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test float equal for Windows #2153

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Fixed test float equal for Windows #2153

merged 2 commits into from
Sep 10, 2023

Conversation

tvukovic-amd
Copy link
Collaborator

Added case to skip test_limits<int,long> while running tests on Windows since int and long have same min and max values

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2153 (8562cca) into develop (b00489b) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head 8562cca differs from pull request most recent head e7f533b. Consider uploading reports for the commit e7f533b to get more accurate results

@@           Coverage Diff            @@
##           develop    #2153   +/-   ##
========================================
  Coverage    91.47%   91.48%           
========================================
  Files          424      424           
  Lines        15860    15871   +11     
========================================
+ Hits         14508    14519   +11     
  Misses        1352     1352           
Files Changed Coverage Δ
src/include/migraphx/op/allocate.hpp 100.00% <100.00%> (ø)

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Sep 6, 2023

Test Batch Rate new
e7f533
Rate old
67b710
Diff Compare
torchvision-resnet50 64 2,283.19 2,284.07 -0.04%
torchvision-resnet50_fp16 64 5,360.94 5,360.36 0.01%
torchvision-densenet121 32 1,815.17 1,841.05 -1.41%
torchvision-densenet121_fp16 32 3,395.37 3,390.96 0.13%
torchvision-inceptionv3 32 1,337.73 1,345.14 -0.55%
torchvision-inceptionv3_fp16 32 2,588.31 2,595.02 -0.26%
cadene-inceptionv4 16 682.02 680.37 0.24%
cadene-resnext64x4 16 589.99 591.03 -0.18%
slim-mobilenet 64 7,223.31 7,214.17 0.13%
slim-nasnetalarge 64 237.08 236.85 0.10%
slim-resnet50v2 64 2,530.58 2,526.48 0.16%
bert-mrpc-onnx 8 721.35 721.47 -0.02%
bert-mrpc-tf 1 389.11 390.08 -0.25%
pytorch-examples-wlang-gru 1 300.75 299.09 0.56%
pytorch-examples-wlang-lstm 1 311.33 310.47 0.28%
torchvision-resnet50_1 1 557.00 554.09 0.53%
torchvision-inceptionv3_1 1 305.84 305.95 -0.04%
cadene-dpn92_1 1 350.58 346.24 1.25%
cadene-resnext101_1 1 220.17 220.33 -0.07%
slim-vgg16_1 1 224.43 224.46 -0.01%
slim-mobilenet_1 1 1,494.20 1,476.74 1.18%
slim-inceptionv4_1 1 221.91 218.72 1.46%
onnx-taau-downsample 1 247.91 247.72 0.07%
dlrm-criteoterabyte 1 21.68 21.68 0.02%
dlrm-criteoterabyte_fp16 1 40.63 40.65 -0.05%
agentmodel 1 5,725.74 5,838.50 -1.93%
unet_fp16 2 55.08 55.02 0.11%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

🔴torchvision-inceptionv3_1: FAILED: MIGraphX is not within tolerance - check verbose output


🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

🔴slim-inceptionv4_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten requested a review from pfultz2 September 6, 2023 14:07
@apwojcik apwojcik added the Windows Related changes for Windows Environments label Sep 6, 2023
@causten causten merged commit 37787e0 into develop Sep 10, 2023
12 checks passed
@causten causten deleted the fix/float_equal branch September 10, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Related changes for Windows Environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants