Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes the version number discrepancy for gradle #107

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

olavtar
Copy link
Collaborator

@olavtar olavtar commented Jun 14, 2024

Description

fixes the version number discrepancy between manifest file and html report

Related issue (if any): fixes TC-1558922782

Checklist

  • [x ] I have followed this repository's contributing guidelines.
  • [x ] I will adhere to the project's code of conduct.

Additional information

Anything else?

Copy link
Collaborator

@zvigrinberg zvigrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Olga,

Thanks for you PR.
We need to discuss how to settle it, as this PR needs to be implemented in a different way.
Let's discuss it today on a 101 call .

…or the package in the dropdown

Signed-off-by: Olga Lavtar <[email protected]>
…or the package in the dropdown

Signed-off-by: Olga Lavtar <[email protected]>
@olavtar olavtar requested a review from zvigrinberg June 24, 2024 15:01
Copy link
Collaborator

@zvigrinberg zvigrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olavtar Good job!.
LGTM, Approved.

@olavtar olavtar merged commit 1146394 into RHEcosystemAppEng:main Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants