fix: ci, .gitignore and rust toolchain updates, lint fixes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicbus
requested changes
Oct 23, 2023
nicbus
changed the title
shuimuliang
changed the title
nicbus
requested changes
Oct 24, 2023
Cargo.lock
Outdated
| @@ -3322,7 +3322,7 @@ dependencies = [ | |||
| "lightning-rapid-gossip-sync 0.0.115 (registry+https://github.com/rust-lang/crates.io-index)", | |||
| "magic-crypt", | |||
| "mime", | |||
| "miniscript 8.0.1", | |||
| "miniscript 8.0.2", | |||
There was a problem hiding this comment.
let's keep the Cargo.lock file as it was before
fix: according to the comments in pr7 ci: strict cargo test & cargo clippy ci: Lint for GitHub workflows build: specify rust target and toolchain for compilation fix: fix: cargo clippy warnings fix: cargo test warnings
nicbus
requested changes
Oct 26, 2023
There was a problem hiding this comment.
@shuimuliang please:
- address the last unresolved conversation (restore the original
Cargo.lockfile) - amend the commit and, while you're at it, update its message (dropping the description as it references changes that have been dropped)
- sign the amended commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.