Add methods to backup & restore wallet #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmalahie
changed the title
nicbus
requested changes
Dec 9, 2024
There was a problem hiding this comment.
a couple points:
- please format the code
- please uniform the
validateTypescalls to the existing ones (which use thevalidateTypes(params, expectedTypes);approach)
as an additional request, would you mind also adding the backup_info API? IMO it makes sense in the context of this PR
tmalahie
force-pushed
the
backup-wallet
branch
from
98d5351 to
68534e6
Compare
zoedberg
requested changes
Dec 11, 2024
tmalahie
force-pushed
the
backup-wallet
branch
from
68534e6 to
c3ada7e
Compare
tmalahie
force-pushed
the
backup-wallet
branch
from
c3ada7e to
e2a5266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary methods to perform the wallet backup mechanism (
backup&restoreBackup)It depends on RGB-Tools/rgb-lib#53