Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue 190 #218

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixing issue 190 #218

wants to merge 7 commits into from

Conversation

ananya2711
Copy link

Added ValueError for invalid select query with RDF return format.
Issue 190

aucampia
aucampia reviewed May 10, 2022
View reviewed changes
SPARQLWrapper/Wrapper.py Outdated
_validate_format("JSON", [JSON], ct, self.requestedFormat)
return self._convertJSON()
elif _content_type_in_list(ct, _RDF_XML):
#Ananya: This has to be altered
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these would cause an error some asserts in the test file.
Altering those too.

@aucampia
Copy link
Member

aucampia commented May 10, 2022 •
edited
Loading

This PR is somehow messing with whitespaces and basically rewrites the entire files (+1,411 −1,406), please can you check your editor and git config to figure out why, merging this will just create blame noise:

image

aucampia
aucampia reviewed May 10, 2022
View reviewed changes
SPARQLWrapper/Wrapper.py
Comment on lines +777 to +778
elif self.returnFormat == RDF:
raise ValueError("A SPARQL SELECT query doesn't return RDF, so RDF here is not a valid selection for a return type. Return types of JSON & XML are valid.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@ghost
Copy link

ghost commented May 10, 2022

This PR is somehow messing with whitespaces and basically rewrites the entire files (+1,411 −1,406), please can you check your editor and git config to figure out why, merging this will just create blame noise:

Windows CR+LF line endings is causing the problem.

@ananya2711 see https://fedingo.com/how-to-configure-line-endings-in-git-commit/

@ananya2711 ananya2711 force-pushed the issue190-ananya2711 branch from b38f20e to 8ffef6e Compare May 12, 2022 23:58
@ananya2711 ananya2711 mentioned this pull request May 13, 2022
Open
@ghost
Copy link

ghost commented May 14, 2022

Please remove the spurious file 6.1.1 and also fix the Windows CR+LF line ending issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucampia aucampia aucampia left review comments

@PritishWadhwa PritishWadhwa PritishWadhwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananya2711 @aucampia @PritishWadhwa @nicholascar