Update kratos ui docker image #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpgxvii
commented
Sep 17, 2024
| | replicaCount | int | `1` | Number of replicas in deployment | | ||
| | revisionHistoryLimit | int | `5` | Number of revisions kept in history | | ||
| | image.repository | string | `"ghcr.io/radar-base/radar-self-enrolment-ui"` | | | ||
| | image.tag | string | `"dev"` | ORY KRATOS VERSION | |
Comment on lines
67
to
71
| | kratosAdminUrl | string | `"http://kratos-admin"` | Set this to ORY Kratos's Admin URL | | ||
| | kratosPublicUrl | string | `"http://kratos-public"` | Set this to ORY Kratos's public URL | | ||
| | kratosBrowserUrl | string | `"http://kratos-browserui"` | Set this to ORY Kratos's public URL accessible from the outside world. | | ||
| | basePath | string | `""` | The basePath | | ||
| | jwksUrl | string | `"http://oathkeeper-api"` | The jwksUrl | |
There was a problem hiding this comment.
Should we fix these url based on the kratos/hydra in our stack?
|
Do we need |
Ah yes, I've just added it here as well. |
yatharthranjan
approved these changes
Sep 27, 2024
|
|
||
| # -- The basePath | ||
| basePath: "" | ||
|
|
||
| # -- The jwksUrl | ||
| jwksUrl: "http://oathkeeper-api" | ||
| jwksUrl: http://oathkeeper-api |
There was a problem hiding this comment.
should this be pointed to hydra too?
| @@ -167,21 +167,24 @@ deployment: | |||
| affinity: {} | |||
|
|
|||
| # -- Set this to ORY Kratos's Admin URL | |||
| kratosAdminUrl: "http://kratos-admin" | |||
| kratosAdminUrl: http://kratos:4434 | |||
There was a problem hiding this comment.
Is this still needed? otherwise can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.