Impl. external config of URLs hard-coded to HTTPS #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pvannierop
force-pushed
the
feature/allow-http-urls
branch
2 times, most recently
from
ba9b687 to
a91b947
Compare
pvannierop
force-pushed
the
feature/allow-http-urls
branch
5 times, most recently
from
132b955 to
df77c35
Compare
keyvaann
reviewed
Jul 23, 2024
| @@ -49,6 +49,7 @@ spec: | |||
| {{- toYaml .Values.securityContext | nindent 12 }} | |||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" | |||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | |||
| {{ $https := ternary "http" "https" (or .Values.disable_tls (not .Values.ingress.tls)) }} | |||
There was a problem hiding this comment.
Let's put this on top of the file
pvannierop
force-pushed
the
feature/allow-http-urls
branch
from
df77c35 to
7eeebe2
Compare
pvannierop
force-pushed
the
feature/allow-http-urls
branch
2 times, most recently
from
b62d460 to
7e5507d
Compare
pvannierop
force-pushed
the
feature/allow-http-urls
branch
from
7e5507d to
66c11aa
Compare
pvannierop
force-pushed
the
feature/allow-http-urls
branch
from
6c8ab0e to
290d194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run and test on a system w/o TLS (e.g., local development system or CI system) some URLs hard-coded to the HTTPS protocol were made configurable.
Discuss
An alternative would be to add a single value disable_tls that selectively chooses between HTTP and HTTPS protocols. This is done f.i. in the Minio chart: